Check todoist due date is not None in async_get_events#36140
Merged
cgarwood merged 2 commits intoMay 26, 2020
Conversation
Check that due date is not None, prevents taks without due dates from breaking Calendar API
boralyl
approved these changes
May 25, 2020
MartinHjelmare
requested changes
May 26, 2020
balloob
pushed a commit
that referenced
this pull request
May 28, 2020
* Check that due date is not None Check that due date is not None, prevents taks without due dates from breaking Calendar API * Invert None check to reduce indentation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that due date is not None, prevents taks without due dates from breaking Calendar API
Breaking change
Proposed change
The Todoist integration throws an error in the async_get_events method if there is a task without a due date, preventing them for working correctly with the Calendar API. This PR adds a check that the due date is not None before checking if the due date is within the date range being requested.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: